Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 Support & CI #1686

Closed
wants to merge 7 commits into from
Closed

Add ARM64 Support & CI #1686

wants to merge 7 commits into from

Conversation

qmfrederik
Copy link
Contributor

libgit2/libgit2sharp.nativebinaries#91 added support for building the native libraries for ARM64.

This PR adds support for building and testing libgit2sharp on ARM64. It uses Drone CI to build & test on native ARM64 hardware. It uses netcoreapp3.0 to run the tests.

@qmfrederik
Copy link
Contributor Author

@bording I got the build more or less working on ARM64 (1 unit test failing) so I thought I'd put out this PR and see if there's any way we can update libgit2sharp and include ARM64 support?

Of particular interest is the dependency on NerdBank.GitVersioning & SourceLink, both which use libgit2sharp and will fail on ARM64 hardware (since they use a version of libgit2sharp which doesn't have ARM64 support).

Is there any way we could 'side-load' an arm64-version of libgit2 that these tasks can use?

@bording
Copy link
Member

bording commented Nov 24, 2024

Lots of things have changed in the repo since this PR was first opened. At this point LibGit2Sharp does have full ARM support.

The one thing we don't have yet is a way to run tests for ARM, but with GitHub Actions saying that ARM runners are coming soon, at this point I'd rather just wait for that vs. introducing a second CI system for it.

@bording bording closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants