This repository has been archived by the owner on Dec 21, 2018. It is now read-only.
Adding services parameters in methods. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpose file, Add pause/unpause methods to start without creating and stop without deleting services.
houndci-bot
reviewed
Sep 5, 2017
compose.go
Outdated
| // Stop shuts down and clean the project | ||
| func (p *Project) Stop() error { | ||
| // FIXME(vdemeester) handle timeout | ||
| func (p *Project) Pause(services ...string) error { |
There was a problem hiding this comment.
exported method Project.Pause should have comment or be unexported
compose.go
Outdated
| return p.UnPause(services...) | ||
| } | ||
|
|
||
| func (p *Project) UnPause(services ...string) error { |
There was a problem hiding this comment.
exported method Project.UnPause should have comment or be unexported
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
====================================
Coverage 0% 0%
====================================
Files 1 1
Lines 91 125 +34
====================================
- Misses 91 125 +34 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
====================================
Coverage 0% 0%
====================================
Files 1 1
Lines 91 125 +34
====================================
- Misses 91 125 +34 |
houndci-bot
reviewed
Sep 6, 2017
compose.go
Outdated
| return p.UnPause(services...) | ||
| } | ||
|
|
||
| // Unpause only starts created services which are stopped. |
There was a problem hiding this comment.
comment on exported method Project.UnPause should be of the form "UnPause ..."
vdemeester
suggested changes
Sep 6, 2017
compose.go
Outdated
| } | ||
|
|
||
| // UnPause only starts created services which are stopped. | ||
| func (p *Project) UnPause(services ...string) error { |
There was a problem hiding this comment.
🤔 pause/unpause are already docker and docker-compose commands so I think it's the wrong name for the method here (i.e. it's going to be confusing).
There was a problem hiding this comment.
Also, does it need to be exported ? 👼
compose.go
Outdated
| func (p *Project) Stop() error { | ||
| // FIXME(vdemeester) handle timeout | ||
| // Pause only stop services without delete them. | ||
| func (p *Project) Pause(services ...string) error { |
This was referenced Sep 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows users to add services as parameters when project is started/stopped.
The pause/unpause methods are added in the way to separate :