Add API compatibity check to travis. #40
Conversation
|
As the author of #37, this seems awesome to me 😄 There are plenty of reasons to break API compatibility, but it's always nice to at least know that you're doing it |
| package core | ||
|
|
||
| import ( | ||
| _ "github.com/smola/gocompat" |
There was a problem hiding this comment.
I read the usage instructions on the gocompat repo, but I'm not sure I follow why we need an import for side-effects here. Isn't the CLI tool self-contained?
There was a problem hiding this comment.
It's how one tricks go mod into tracking it. That way, one can run go run github.com/smola/gocompat/cmd/gocompat and always get the right version.
There was a problem hiding this comment.
The build tag is made such that it isn't used for the build and as @Stebalien said. This is how one tricks gomod into tracing tooling. We use the same technique in go-ipfs and go-filecoin is doing the same.
There was a problem hiding this comment.
What a hack... sigh scope=test in Maven, devDependencies in npm.
.travis.yml
Outdated
| include: | ||
| - stage: "Test" | ||
| script: "./compat-check" | ||
| name: "Compatibility Test" |
There was a problem hiding this comment.
| name: "Compatibility Test" | |
| name: "API compatibility test" |
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feat/compat-check
branch
from
4bc67d7 to
04ad8ae
Compare
|
I've removed the breaking change and changed the line. |
Resolves #39