-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add peerstore spec and protobuf #91
base: main
Are you sure you want to change the base?
Conversation
There are more functions in the Peerstore interface. Also, don't expose |
The only other two methods I can see being useful to expose would be
Probably also the majority of the AddrBook.
|
There are more interfaces it implements. |
It's not implemented and I don't intend to add it, are you referring to Is |
Yes, both are not to be used willy nilly.
fair enough. |
I've added some more types based on the available interfaces. If those look good I will add accompanying specs for those requests. I didn't include the |
Now this is probably too much; we need to be a little more selective for utility here :) |
Here's an updated list. I removed metrics as that's probably unnecessary at this point. I think this gives us a good base for interacting with the Peerstore. Peer operations Address operations Key Operations |
That looks better. @bigs opinions? |
cc @raulk |
This adds a subset of commands to interact with the Peerstore.
ADD_PROTOCOLS
,GET_PROTOCOLS
,GET_PEER_INFO
Resolves #89