[WIP] rate limit dials #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Closing as this demonstrates the issue but isn't the right solution. |
|
Background: dialling wasn't honouring the alpha concurrency factor, so we ended up dialling every single peer that got reported to us in |
10s covers the 99.9th percentile of internet RTTs. > Aikat, J., Kaur, J., Smith, F. D., & Jeffay, K. (2003, October). Variability > in TCP round-trip times. In Proceedings of the 3rd ACM SIGCOMM conference on > Internet measurement (pp. 279-284). ACM.
We sort inside the queue itself but *only* if there's actually a backlog.
We may now have better candidates to query.
Stebalien
force-pushed
the
fix/rate-limit-dials
branch
from
c41f37a to
ce55f94
Compare
|
Replaced with #229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of releasing the rate-limit when dialing, keep it. Dialing is the most expensive part.