Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go mod files #251

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Add go mod files #251

merged 2 commits into from
Feb 7, 2019

Conversation

anacrolix
Copy link
Contributor

Adds go mod files. It looks like #236 is stalled. CircleCI is already testing go mod support, so this will augment that. When #236, or something using "compatible" major versioning does go through (if ever), the migration should be seamless.

@ghost ghost assigned anacrolix Feb 7, 2019
@ghost ghost added the status/in-progress In progress label Feb 7, 2019
@anacrolix anacrolix requested a review from raulk February 7, 2019 02:25
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gomod build succeeded on CI. gx one failed but due to flaky test. Based on this, LGTM.

@anacrolix anacrolix merged commit 0ab2731 into master Feb 7, 2019
@ghost ghost removed the status/in-progress In progress label Feb 7, 2019
@anacrolix anacrolix deleted the go-mod-turds branch February 7, 2019 23:11
@lanzafame
Copy link
Contributor

@raulk why wasn't this issue raised here as well?

@lanzafame lanzafame mentioned this pull request Feb 11, 2019
@raulk
Copy link
Member

raulk commented Feb 19, 2019

@lanzafame yeah, just saw that now. I assumed it had been taken care of, but it wasn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants