Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4 - Add immutable remove operation #14

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Fixes #4 - Add immutable remove operation #14

merged 2 commits into from
Jul 14, 2021

Conversation

xprazak2
Copy link
Contributor

No description provided.

petar
petar requested changes Jun 28, 2021
View reviewed changes
trie/remove.go Outdated Show resolved Hide resolved
trie/remove.go Show resolved Hide resolved
@xprazak2
Copy link
Contributor Author

xprazak2 commented Jul 4, 2021

Thank you for your review, updated.

petar
petar requested changes Jul 6, 2021
View reviewed changes
Copy link
Collaborator

@petar petar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good now. Thank you! You need to run gofmt before we can submit.

@xprazak2
Copy link
Contributor Author

Thanks, I updated the formatting.

@petar petar merged commit 5c005ac into libp2p:master Jul 14, 2021
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petar petar petar requested changes

Assignees

@petar petar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xprazak2 @petar