Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mDNS discovery announces ephemeral ports #254

Closed
ghost opened this issue Dec 13, 2017 · 1 comment
Closed

mDNS discovery announces ephemeral ports #254

ghost opened this issue Dec 13, 2017 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@ghost
Copy link

ghost commented Dec 13, 2017

I've seen that a while ago:

19:03:19.522 DEBUG       mdns: Handling MDNS entry: 192.168.43.135:36191  mdns.go:147

We should only ever announce what's in Addresses.Swarm or Addresses.Announce
@ghost ghost added the kind/bug A bug in existing code (including security flaws) label Dec 13, 2017
marten-seemann added a commit that referenced this issue Aug 17, 2022
@marten-seemann
force usage of github.com/btcsuite/btcd v0.22.1 or newer (#254)
10ad673
@marten-seemann
Copy link
Contributor

We're announcing the addresses of all interfaces we're listening on:

go-libp2p/p2p/discovery/mdns/mdns.go

Line 113 in 1e31d70

interfaceAddrs, err := s.host.Network().InterfaceListenAddresses()

I believe this is correct, albeit slightly suboptimal (we could have a separate mDNS service per interface).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marten-seemann