-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move go-tcp-transport here #1418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It got skipped when go-reuseport got migrated to context
fix(govet): correct fmt for bool is %t
Update go-reuseport, fix context passing, publish 1.0.2
The tpt.ConnWrap is being removed from go-libp2p-transport
Timeout should only be set by using contexts.
Compatibility with the new transport interfaces
This reverts commit 21fd167.
Revert the new Conn interfaces
1. Migrate to libp2p repo. 2. Pull in fixes for edge platforms. Related: use `x/sys` instead of `syscall` when possible. 3. Pull in less complicated and slightly faster dial logic.
fix source address not being set in non REUSEPORT dialer
update go-reuseport
Set source port iff using reuseport
Also, refactor out reuseport logic into a separate package.
refactor for transport interface changes
collect metrics in a separate go routine
chore: update go-libp2p-transport-upgrader and go-reuseport-transport
disable metrics collection on Windows
From the documentation: WithDeadline returns a copy of the parent context with the deadline adjusted to be no later than d. If the parent's deadline is already earlier than d, WithDeadline(parent, d) is semantically equivalent to parent.
simplify dial timeout context
chore: update go-log to v2
use the assigned role when upgrading a sim open connection
remove the deprecated IPFS_REUSEPORT command line flag
use the transport.Upgrader interface
use the ResourceManager
It _looks_ like the standard library doesn't always wrap this error. fixes #113
vyzo
approved these changes
Apr 22, 2022
marten-seemann
force-pushed
the
merge-tcp
branch
from
April 22, 2022 13:48
ac153a7
to
dfc3a3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1187.