holepunch: fix incorrect message type for the SYNC message #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
May 10, 2022
|
how did it work? |
vyzo
requested changes
May 10, 2022
It did before the refactor. We didn't do any manual end-to-end testing after the refactor. Yet another reason why we need Testground tests for this...
The current implementation doesn't send any SYNC. Before the refactoring, this was https://github.com/libp2p/go-libp2p/blob/v0.18.1/p2p/protocol/holepunch/coordination.go#L204-L210 (unfortunately git doesn't produce helpful diffs when you split one file into two, so this was easy to miss). |
marten-seemann
added a commit
that referenced
this pull request
May 10, 2022
marten-seemann
added a commit
that referenced
this pull request
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1477.
This is bad. We'll need to backport this and release v0.19.2.