Improve ObservedAddrSet behaviour #191
Conversation
Kubuxu
force-pushed
the
feat/identify/smarter-obsaddrs
branch
from
cb0d3a8 to
963ce97
Compare
p2p/protocol/identify/obsaddr.go
Outdated
| @@ -8,15 +8,32 @@ import ( | |||
| ma "github.com/multiformats/go-multiaddr" | |||
| ) | |||
|
|
|||
| const ActivationTrsh = 4 | |||
There was a problem hiding this comment.
s/Trsh/Thresh/ Looks less like 'Trash'
p2p/protocol/identify/obsaddr.go
Outdated
| // ObservedAddr is an entry for an address reported by our peers. | ||
| // We only use addresses that: | ||
| // - have been observed more than once. (counter symmetric nats) | ||
| // - have been observed recently (10min), because our position in the | ||
| // - have been observed more than 3 times in last 10 min. (counter symmetric nats) |
There was a problem hiding this comment.
This one should be more than ten minutes I think. Can probably get away with making it an hour
There was a problem hiding this comment.
I would extend the time of the aspect explained lower. After it was observed and confirmed (4 observations in 10 min duration) keep it as valid address for an hour. How does that sound?
There was a problem hiding this comment.
And it is an hour that is extended every time address is observed by anyone again.
There was a problem hiding this comment.
I think the four observations should be able to occur over a longer timespan than ten minutes.
p2p/protocol/identify/obsaddr.go
Outdated
| ma "github.com/multiformats/go-multiaddr" | ||
| ) | ||
|
|
||
| const ( | ||
| ActivationTresh = 4 |
There was a problem hiding this comment.
Close, s/Tresh/Thresh
p2p/protocol/identify/obsaddr.go
Outdated
| @@ -69,7 +80,7 @@ func (oas *ObservedAddrSet) Add(addr ma.Multiaddr, observer ma.Multiaddr) { | |||
| // for zero-value. | |||
| if oas.addrs == nil { | |||
| oas.addrs = make(map[string]*ObservedAddr) | |||
| oas.ttl = pstore.OwnObservedAddrTTL | |||
| oas.ttl = OwnObservedAddrTTL | |||
There was a problem hiding this comment.
Sure we want to disconnect this?
There was a problem hiding this comment.
I switched back and opened. libp2p/go-libp2p-peerstore#13
|
also tests are failing |
Kubuxu
force-pushed
the
feat/identify/smarter-obsaddrs
branch
5 times, most recently
from
0ba432b to
0dee2f4
Compare
|
Oh, there shouldn't be hash update here. It slipped in. |
Kubuxu
force-pushed
the
feat/identify/smarter-obsaddrs
branch
from
2e966e2 to
ed98e37
Compare
change backoffs to per-address
optimize allocations in the memory address book
* run go mod tidy
* omit receiver name if unused
* remove unused type testkey in tests
* fix duplicate import of go-multiaddr
* fix use of deprecated peer.IDB58{Encode,Decode}
* use bytes.Equal instead of bytes.Compare
* fix unnecessary assigments to blank identifier
* use time.Until instead of t.Sub(time.Now())
* fix use of deprecated go-multihash.ID
* add missing error check in envelope test
* fix error check in tests
No description provided.