Update circuitv2 to proto3 #2029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Before merging we need to update the proto files now that libp2p/specs#511 is in. Feel free to do so @ckousik, otherwise I'll pick this up tomorrow. I think we are fine to merge this after we make the next release. |
|
@ckousik are you picking this up or is Marco? |
|
@p-shahi I'm unable to add any reviewers. |
|
@ckousik Is this ready for review? |
|
@marten-seemann yes, just marked it ready for review |
MarcoPolo
requested changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates circuit v2 to use proto3. Currently awaiting issue to be resolved and spec to be updated libp2p/specs#509