Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: update CI config files #2073

Merged
merged 13 commits into from
Feb 12, 2023
Merged

sync: update CI config files #2073

merged 13 commits into from
Feb 12, 2023

Conversation

web3-bot
Copy link
Collaborator

@web3-bot web3-bot commented Feb 8, 2023

No description provided.

@MarcoPolo
Copy link
Collaborator

Error: /Users/runner/go/pkg/mod/github.com/lucas-clemente/[email protected]/internal/qtls/go120.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet. For more details, please see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.20 yet. F...) as int value in variable declaration

Sounds like we need to update quic-go before merging.

@marten-seemann
Copy link
Contributor

Error: /Users/runner/go/pkg/mod/github.com/lucas-clemente/[email protected]/internal/qtls/go120.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet. For more details, please see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.20 yet. F...) as int value in variable declaration

Sounds like we need to update quic-go before merging.

For the examples, yes. And that requires releasing v0.25.

@MarcoPolo
Copy link
Collaborator

Ah I missed this was in the examples

@MarcoPolo MarcoPolo mentioned this pull request Feb 9, 2023
Merged
@marten-seemann marten-seemann force-pushed the web3-bot/sync branch 2 times, most recently from f04dbdc to 4e67c27 Compare February 11, 2023 22:54
marten-seemann
marten-seemann reviewed Feb 12, 2023
View reviewed changes
p2p/test/reconnects/reconnect_test.go
@@ -80,10 +81,10 @@ func runRound(t *testing.T, hosts []host.Host) {
var wg sync.WaitGroup
wg.Add(numStreams)
for i := 0; i < numStreams; i++ {
data := make([]byte, rand.Intn(maxDataLen)+1)
rnd.Read(data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

math/rand.Read:

Read should not be called concurrently with any other Rand method.

@marten-seemann marten-seemann merged commit 3a66ff8 into master Feb 12, 2023
This was referenced Feb 12, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web3-bot @MarcoPolo @marten-seemann