use atomic.Bool instead of int32 operations #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
changed the title
sukunrt
force-pushed
the
use-atomic-bool
branch
from
110f440 to
73168c5
Compare
marten-seemann
approved these changes
Feb 13, 2023
That would be great! Thank you! |
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2043
@marten-seemann
There are a bunch of uses of int32 and int64 as atomic counters with atomic.AddInt32 or atomic.AddInt64. We can replace those with atomic.Int32 and atomic.Int64. Should I change those too?