quic: don't send detailed error messages when closing connections #2112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1928.
I know this PR will make some people unhappy, but we really shouldn't send the peer a detailed error message here, as this might allow an attacker to gain a lot of insight into how a node under attack is coping with the attack. This error message has proved useful in debugging recent incidents on the IPFS network, but ultimately it's the wrong solution to the problem.
For example:
Instead, we should have error codes: libp2p/specs#479