swarm: add ip_version to metrics #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
swarm-metrics-ip-version
branch
from
247e458 to
ae2b077
Compare
sukunrt
force-pushed
the
swarm-metrics-ip-version
branch
from
ae2b077 to
dd397d4
Compare
sukunrt
force-pushed
the
swarm-metrics-ip-version
branch
from
dd397d4 to
a54bcaf
Compare
sukunrt
commented
Feb 17, 2023
Comment on lines
+113
to
+122
| ma.ForEach(addr, func(c ma.Component) bool { | ||
| if c.Protocol().Code == ma.P_IP4 { | ||
| version = "ip4" | ||
| return false | ||
| } else if c.Protocol().Code == ma.P_IP6 { | ||
| version = "ip6" | ||
| return false | ||
| } | ||
| return true | ||
| }) |
There was a problem hiding this comment.
@marten-seemann addr.ValueForProtocol(ma.P_IP4) allocates on heap, so doing it this way.
There was a problem hiding this comment.
Yes that's fine. Our multiaddr API isn't the cleanest...
marten-seemann
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2106