-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelog: improve description of smart dialing #2342
Conversation
Do you want to mention the two metrics for tracking smart dialing impact? |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a suggestion about being a bit more precise so someone can get a hold of the impact, but otherwise looks great - thanks.
Our measurements on the IPFS network show that for >90% of established libp2p connections, the first connection attempt succeeds, | ||
leading a dramatic decrease in the number of aborted connection attempts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put numbers to this to inform how dramatic this was? For example, I think the "Cancel fraction" we had in #2260 (comment) was useful.
I'm thinking about what we'd say in a presentation or all hands. Is this reducing the number of "wasted" connections by 50%, 75%, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the numbers again for master branch. This is reducing the number of "wasted" connections by 50%.
With no smart dialing 60% of all connection attempts are cancelled. With smart dialing turned on 30% of all connection attempts are cancelled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can report numbers here, or on the next release when we have black hole detection (or both). I expect the numbers to be significantly better when we have that, as there are quite a few dual stack hosts in the network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will report the exact numbers when we turn smart dialing on by default.
I like the detailed changelog entry! Very helpful as an outsider. |
No description provided.