-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mulit-protocol app with protobufs #281
Conversation
Feat/multipro example
Looks like Travis complains about missing dep |
you need to use gogo protobuf. |
I'm familiar with goog. Unfortunately, this import is in the go generated file from the proto file. |
You need to generate the proto file with gogo protobuf; there is already a dependency for it. |
Unfortunately even using |
use |
ok - I think I sorted out with my latest commit. |
ok, so the proto file is now generated with gogo as recommended but Travis is still upset. Local builds work. |
i think you might need to use the version in gx; do you mind if i fix this? |
oh i can't push to this. |
Please FIX - it is a major PITA to deal with GOGO. I have the latest google protobufs and latest gogo but there's still an issue with generating the protobufs once we customize to use gogo so go builds failed due to a compile time assertion. |
I can't without opening a new PR in a feature branch where i can push. |
Or we can use the other PR, since the branch is still alive and open. I will merge your master and update there. |
Can't you just open a PR such as this one so I can merge it? avive#1 |
too much work, it's easier to use the extant pr; it will be the same commits. |
merged and regenerated in #280; closing this. |
Merged fixes. Tested. Should be good to go!