Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mulit-protocol app with protobufs #281

Closed
wants to merge 61 commits into from
Closed

Mulit-protocol app with protobufs #281

wants to merge 61 commits into from

Conversation

avive
Copy link
Contributor

@avive avive commented Feb 22, 2018

Merged fixes. Tested. Should be good to go!

@avive
Copy link
Contributor Author

avive commented Feb 22, 2018

Looks like Travis complains about missing dep github.com/golang/protobuf/proto

@vyzo
Copy link
Contributor

vyzo commented Feb 22, 2018

you need to use gogo protobuf.

@avive
Copy link
Contributor Author

avive commented Feb 22, 2018

I'm familiar with goog. Unfortunately, this import is in the go generated file from the proto file.
Please consider adding github.com/golang/protobuf/proto as a GX dep to resolve. thanks!

@vyzo
Copy link
Contributor

vyzo commented Feb 22, 2018

You need to generate the proto file with gogo protobuf; there is already a dependency for it.

@avive
Copy link
Contributor Author

avive commented Feb 22, 2018

Unfortunately even using protoc --gofast_out=. *.proto generates a dep to github.com/golang/protobuf/proto for me and it is not quite clear how to override this with the info provided here https://github.com/gogo/protobuf

@vyzo
Copy link
Contributor

vyzo commented Feb 22, 2018

use --gogo_out or --gogofast_out; you will need to install it first.

@avive
Copy link
Contributor Author

avive commented Feb 22, 2018

ok - I think I sorted out with my latest commit.

@avive
Copy link
Contributor Author

avive commented Feb 22, 2018

ok, so the proto file is now generated with gogo as recommended but Travis is still upset. Local builds work.

@vyzo
Copy link
Contributor

vyzo commented Feb 22, 2018

i think you might need to use the version in gx; do you mind if i fix this?

@vyzo
Copy link
Contributor

vyzo commented Feb 22, 2018

oh i can't push to this.

@avive
Copy link
Contributor Author

avive commented Feb 22, 2018

Please FIX - it is a major PITA to deal with GOGO. I have the latest google protobufs and latest gogo but there's still an issue with generating the protobufs once we customize to use gogo so go builds failed due to a compile time assertion.

@vyzo
Copy link
Contributor

vyzo commented Feb 22, 2018

I can't without opening a new PR in a feature branch where i can push.

@vyzo
Copy link
Contributor

vyzo commented Feb 22, 2018

Or we can use the other PR, since the branch is still alive and open.

I will merge your master and update there.

@avive
Copy link
Contributor Author

avive commented Feb 22, 2018

Can't you just open a PR such as this one so I can merge it? avive#1

@vyzo
Copy link
Contributor

vyzo commented Feb 22, 2018

too much work, it's easier to use the extant pr; it will be the same commits.

@vyzo
Copy link
Contributor

vyzo commented Feb 22, 2018

merged and regenerated in #280; closing this.
If you have futher fixes let me know and I can pull them from your master, but you really should be using a development branch for PRs.

@vyzo vyzo closed this Feb 22, 2018
marten-seemann added a commit that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants