quicreuse: make it possible to use an application-constructed quic.Transport #3122
Conversation
We shouldn't create the listener entry. This happens once the libp2p QUIC transport starts listening.
marten-seemann
force-pushed
the
raw-quic-conn
branch
from
1f91bbf to
8db5f55
Compare
p2p/transport/quicreuse/connmgr.go
Outdated
| refCountedTr := &refcountedTransport{ | ||
| QUICTransport: tr, | ||
| packetConn: conn, | ||
| isExternal: true, |
There was a problem hiding this comment.
Does the actual owner of this transport want to know when libp2p will be done with it? My guess is yes.
Any preference for how this looks? We could accept a callback or we could return a done channel. Either way, we'd signal done when we otherwise would have closed this transport (in the case of a non "external" transport). This allows the actual owner to know when it is safe to free the transport.
There was a problem hiding this comment.
I'm not sure there's a lot of value in that. The only reason why libp2p would be done with this transport is when the host is closed, which is something that the owner of the transport initiated himself (by calling Host.Close). Or am I missing something?
There was a problem hiding this comment.
That's fair, but I think it would be a bit simpler if this package doesn't have to consider a Host for managing the lifecycle of this resource. Users could still simply ignore this signal and free after they've closed the host.
Without this, you may be closing the transport before the connmgr is actually done with it.
There was a problem hiding this comment.
done in d8cc67d. Has the nice side-effect of removing the conditional branches around isExternal.
MarcoPolo
force-pushed
the
raw-quic-conn
branch
from
404c3a5 to
cee8044
Compare
It would be nice if the application was able to construct its own
quic.Transport, and have that transport used by libp2p.This would allow an application:
tls.Configon theListencall, andAccept(a subset of) QUIC connections returned by the listenerThis would make it possible to run a vanilla HTTP/3 server behind a NAT / firewall and use libp2p's NAT hole punching mechanism to create the NAT bindings.