p2p/net/swarm: improve code coverage #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
added
status/in-progress
marten-seemann
added a commit
that referenced
this pull request
Jan 17, 2022
add an error return value to the constructor
marten-seemann
pushed a commit
that referenced
this pull request
Apr 21, 2022
Refactor and relax filtering of known undialable addresses
marten-seemann
pushed a commit
that referenced
this pull request
Aug 9, 2022
Feels like Java all over again. fixes #87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes some dead code and adds more tests, hits 82.8% code coverage