Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Debugging issue 43 #45

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Debugging issue 43 #45

wants to merge 1 commit into from

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Apr 27, 2019

Debugging #43

  • assert that the reader doesn't over-read, which is what seems to be happening in the crash log.

@ghost ghost assigned vyzo Apr 27, 2019
@ghost ghost added the status/in-progress In progress label Apr 27, 2019
@vyzo
Copy link
Contributor Author

vyzo commented Apr 27, 2019

Note that I have tagged v0.0.2 in bfa0084 to overcome breakage in go mod.

@vyzo vyzo mentioned this pull request Apr 28, 2019
Closed
@vyzo
Copy link
Contributor Author

vyzo commented Apr 28, 2019

Closing, as it seems to have exceeded its utility; the bug was diagnosed as an oversized read.

@vyzo vyzo closed this Apr 28, 2019
@ghost ghost removed the status/in-progress In progress label Apr 28, 2019
@vyzo vyzo deleted the debug/issue-43 branch May 9, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vyzo vyzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vyzo