Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't reset on pathologies, just ignore the data #57

Merged
merged 1 commit into from
May 22, 2019
Merged

don't reset on pathologies, just ignore the data #57

merged 1 commit into from
May 22, 2019

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented May 22, 2019

commented out for now, but we should probably drop this altogether.

@vyzo vyzo requested a review from Stebalien May 22, 2019 17:43
Stebalien
Stebalien approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to:

  1. Make this error detection more robust.
  2. Kill the entire connection when a protocol violation happens.

But this does fix the immediate issue.

@vyzo
Copy link
Contributor Author

vyzo commented May 22, 2019

agreed.

@vyzo vyzo merged commit 54e6e16 into master May 22, 2019
@vyzo vyzo deleted the fix/fewer-resets branch May 22, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyzo @Stebalien