Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for specifying noise #32

Merged
merged 8 commits into from
Apr 22, 2020
Merged

feat: add support for specifying noise #32

merged 8 commits into from
Apr 22, 2020

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Feb 9, 2020

This adds support for being able to specify transport cryptos SECIO and Noise via the respective boolean flags --secio and --noise. This is designed to match the configuration options for the go daemon PR.

TODO

  • Add test runs for both secio and noise (depends on a stable version of libp2p-noise) (skipping this as we plan to deprecate secio anyway, might as well focus on noise testing going forward)

Relates to libp2p/go-libp2p-daemon#158

src/libp2p.js Outdated Show resolved Hide resolved
src/libp2p.js Outdated Show resolved Hide resolved
@jacobheun
Copy link
Contributor Author

Per suggestions this now uses the exported NOISE constructor.

@jacobheun jacobheun marked this pull request as ready for review April 22, 2020 13:27
@jacobheun jacobheun requested a review from vasco-santos April 22, 2020 13:28
@jacobheun
Copy link
Contributor Author

I bumped noise to the 1.0 release, I think this should be ready to go.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated Show resolved Hide resolved
Co-Authored-By: Vasco Santos <[email protected]>
@jacobheun jacobheun merged commit e5582cd into master Apr 22, 2020
@jacobheun jacobheun deleted the feat/noise branch April 22, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants