This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
fix!: remove getPublicKey method #376
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getPublicKey method can be used to fetch the public key of a
peer that uses an RSA peer id.
This method is redundant as it can be accomplished by using content
routing to look up the value for the `/pk` key. E.g
```js
const peerKey = uint8ArrayConcat([
uint8ArrayFromString('/pk/'),
peer.multihash.digest
])
const key = await node.contentRouting.get(peerKey)
```
BREAKING CHANGE: the getPublicKey method has been removed
maschad
approved these changes
May 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getPublicKey method can be used to fetch the public key of a peer that uses an RSA peer id.
The same thing can be accomplished by using content routing to look up the value for the
/pkkey. E.gBREAKING CHANGE: the getPublicKey method has been removed