Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Add message signing support #16

Closed
2 tasks done
jacobheun opened this issue May 3, 2019 · 1 comment
Closed
2 tasks done

Add message signing support #16

jacobheun opened this issue May 3, 2019 · 1 comment
Assignees
@jacobheun
Labels
kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP status/in-progress In progress

Comments

@jacobheun
Copy link
Contributor

jacobheun commented May 3, 2019 •
edited by vasco-santos
Loading

Go is looking to turn message signing on by default and rolled out to the daemon and IPFS. The change has already been done, but the rollout process is still underway. We need to get message signing support added to js pubsub. We can do this in two phases to split up the work:

  • 1. Add support for message signing and sign outgoing messages by default
  • 2. Verify the signatures of incoming messages (before they go through validators)

Ref: libp2p/go-libp2p-pubsub#179
@jacobheun jacobheun added kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked P0 Critical: Tackled by core team ASAP labels May 3, 2019
@jacobheun jacobheun self-assigned this May 3, 2019
This was referenced May 6, 2019
Merged
Merged
@jacobheun jacobheun added status/in-progress In progress and removed status/ready Ready to be worked labels May 6, 2019
@vasco-santos
Copy link
Member

Closed by #17 and #20

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jacobheun jacobheun

Labels
kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobheun @vasco-santos