This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
feat: verify signatures #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
reviewed
Jul 8, 2019
There was a problem hiding this comment.
Thanks for adding this @jacobheun !
Just found 2 minor things that I would like you to have a look
| } | ||
|
|
||
| module.exports = { | ||
| messagePublicKey, |
There was a problem hiding this comment.
We don't need to, but I could see value in having a utility for unmarshalling keys from messages, especially once key inlining is supported. We could remove it for now, but I don't think it's necessary.
test/pubsub.spec.js
Outdated
| SignPrefix, | ||
| Message.encode(normalizeOutRpcMessage(message)) | ||
| ]) | ||
| // const bytesToSign = Buffer.concat([ |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to pubsub,
strictSigningwhich defaults totrue. Whenvalidateis called, the signature of the message will be verified, unlessstrictSigningis disabled.I originally intended to enforce this at the pubsub interface layer so that both Floodsub and Gossipsub could get the behavior out of the box, however, the implementations don't use the same message processing pipeline. Ideally, we should unify this more so that the abstraction layer can do common validation, like signature validation, before moving on to implementation specific message processing.
As it stands,
validateis going to need to be called in both implementations in their respective pipelines. I will be creating PRs for both implementations.