Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix: catch thrown maConn errors in listener #122

Merged
merged 1 commit into from
Feb 14, 2020
Merged

fix: catch thrown maConn errors in listener #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/listener.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ module.exports = ({ handler, upgrader }, options) => {
// Avoid uncaught errors caused by unstable connections
socket.on('error', err => log('socket error', err))

const maConn = toConnection(socket, { listeningAddr })
log('new inbound connection %s', maConn.remoteAddr)

let maConn
let conn
try {
maConn = toConnection(socket, { listeningAddr })
log('new inbound connection %s', maConn.remoteAddr)
conn = await upgrader.upgradeInbound(maConn)
} catch (err) {
log.error('inbound connection failed to upgrade', err)
return maConn.close()
log.error('inbound connection failed', err)
return maConn && maConn.close()
}

log('inbound connection %s upgraded', maConn.remoteAddr)
Expand Down