-
Notifications
You must be signed in to change notification settings - Fork 16
Restrict Max Message Size #158
Comments
Hey! can you check out the PR #147 ? It is solving this problem without putting any restrictions on message size, instead since we are doing ordered messages, and use 'it-length-prefixed', we can chunk the message up to appropriate sizes and aggregate them on the other end without any issues. The message size option I provided there is basically the chunk size. If you don't like that route, just putting a message size error will not be enough (from the information I gathered) you also needs to make sure that the underlying buffer of webrtc does not exceed this, since message seems to be sent in batches (?) or there are other limits at play here. See this thread. I am trying to update the PR but the build is breaking in main in this repository so I can't resolve merge conflicts at the moment. |
See my comment on the previous issue.
Good find, I think that fix should address this issue. main CI seems to be working at b3cb445 please rebase off that commit. |
Originally posted by @maschad in #144 (comment)
We should throw an error if it the message size exceeds this limit
The text was updated successfully, but these errors were encountered: