fix: confirm external ip (#2895)

Confirm the public ip, not the private one
libp2p · Dec 13, 2024 · 52f0f2f · 52f0f2f
1 parent a08229b
commit 52f0f2f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/upnp-nat/src/upnp-port-mapper.ts b/packages/upnp-nat/src/upnp-port-mapper.ts
@@ -202,7 +202,7 @@ export class UPnPPortMapper {
           this.log('created mapping of %s:%s to %s:%s for protocol %s', mapping.internalHost, mapping.internalPort, mapping.externalHost, mapping.externalPort, transport)
 
           if (options?.autoConfirmAddress === true) {
-            const ma = multiaddr(`/ip${family}/${host}/${transport}/${port}`)
+            const ma = multiaddr(`/ip${isIPv4(mapping.externalHost) ? 4 : 6}/${mapping.externalHost}/${transport}/${mapping.externalPort}`)
             this.log('auto-confirming IP address %a', ma)
             this.addressManager.confirmObservedAddr(ma, {
               ttl: MAX_DATE - Date.now()