Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add public/private key type disambiguators #2698

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: add public/private key type disambiguators #2698

merged 1 commit into from
Sep 12, 2024

Conversation

achingbrain
Copy link
Member

To give typescript some hints about object types, add isPrivateKey and isPublicKey functions.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: add public/private key type disambiguators
ccf539e 
To give typescript some hints about object types, add `isPrivateKey`
and `isPublicKey` functions.
@achingbrain achingbrain requested a review from a team as a code owner September 12, 2024 08:36
@achingbrain achingbrain merged commit 18dd3cb into main Sep 12, 2024
21 checks passed
@achingbrain achingbrain deleted the fix/add-key-disambiguators branch September 12, 2024 08:59
@achingbrain achingbrain mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain