feat: add ConnectionManager#getAll #660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is almost identical to
ConnectionManager#get
except instead of returning the first open connection or null,getAll
returns an array of all open connections (or an empty array).Perhaps
get
could be refactored to usegetAll
to avoid code duplication?Open to any suggestions, naming, implementation, otherwise
See ChainSafe/js-libp2p-gossipsub#83 (comment)