Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all uses of {In,Out}boundUpgrade in transports to {In,Out}boundConnectionUpgrade #4521

Closed
1 of 5 tasks
Tracked by #2863
thomaseizinger opened this issue Sep 20, 2023 · 0 comments · Fixed by #4695
Closed
1 of 5 tasks
Tracked by #2863

Change all uses of {In,Out}boundUpgrade in transports to {In,Out}boundConnectionUpgrade #4521

thomaseizinger opened this issue Sep 20, 2023 · 0 comments · Fixed by #4695

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Sep 20, 2023 •
edited
Loading

As a follow-up to #4307, we need to change the use of the {In,Out}boundUpgrade traits in all transports to use the new traits. This is a breaking change so must happen as part of the next v0.53.0 release.

Tasks
Preview Give feedback
  5. Removing libp2-deflate from workspace #4522
    thomaseizinger
@thomaseizinger thomaseizinger mentioned this issue Sep 20, 2023
Open
@thomaseizinger thomaseizinger added this to the v0.53.0 milestone Sep 20, 2023
@thomaseizinger thomaseizinger mentioned this issue Oct 20, 2023
Merged
4 tasks
@thomaseizinger thomaseizinger removed this from the v0.53.0 milestone Oct 20, 2023
@mergify mergify bot closed this as completed in #4695 Oct 21, 2023
mergify bot pushed a commit that referenced this issue Oct 21, 2023
@thomaseizinger
refactor: migrate upgrades to {In,Out}boundConnectionUpgrade
ed02a10 
This needs to be done in one PR because we need to remove the blanket impl at the same time we add the new ones. I also chose to duplicate `SelectUpgrade` for the `libp2p::SwarmBuilder` because the `SelectUpgrade` within `libp2p-core` is really only meant to be used for protocol upgrade (which will go away at some point). This tiny bit of code duplication doesn't hurt and will help us in the future.

Resolves: #4521.

Pull-Request: #4695.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: migrate upgrades to {In,Out}boundConnectionUpgrade libp2p/rust-libp2p
1 participant
@thomaseizinger