Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webRTC doesn't work with request-response #5438

Closed
DougAnderson444 opened this issue Jun 3, 2024 · 3 comments · Fixed by #5439
Closed

webRTC doesn't work with request-response #5438

DougAnderson444 opened this issue Jun 3, 2024 · 3 comments · Fixed by #5439

Comments

@DougAnderson444
Copy link
Contributor

Summary

After trying many different ways to use Req-Resp over WebRTC, I saw that it just doesn't work.

There is a bug in WebRTC utils, PR to fix is incoming shortly.

Expected behavior

Request-Response protocol should work over WebRTC

Actual behavior

The stream is dropped and the response is never sent or received

Relevant log output

No response

Possible Solution

Fix WebRTC-utils

Version

0.54.0

Would you like to work on fixing this bug ?

Yes

@dariusc93
Copy link
Member

Interesting. Didnt the universal-connectivity use request-response for files? Would have thought it would be caught there.

@DougAnderson444
Copy link
Contributor Author

Likely not over WebRTC, I will take a look

@DougAnderson444
Copy link
Contributor Author

Looks like the universal-connectivity is using the JavaScript for the file upload since it's got the front end, WebRTC and WebTransport

@mergify mergify bot closed this as completed in #5439 Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants