fix(webrtc-utils): read buffer only if empty message #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise return Ok(0), so that reader of the stream know it has ended and is now empty
dariusc93
reviewed
Jun 4, 2024
not a breakign change, we don't need a major version
dariusc93
approved these changes
Jun 4, 2024
jxs
approved these changes
Jun 5, 2024
|
A minor release would be great, I was wondering what the release schedule is like these days? |
|
released |
DougAnderson444
added a commit
to PeerPiper/peerpiper
that referenced
this pull request
Jun 14, 2024
since libp2p-webrtc-utils has now been released as per libp2p/rust-libp2p#5439
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this pull request
Sep 14, 2024
This PR adds a return of `Poll::Ready(Ok(0))` when the `message` vector is empty or not present. This missing return was causing the stream not to finish, then to be dropped, causing the request response protocol to fail over WebRTC. Now that empty or non existent message vectors get returned as `Ok(0)` the stream can be read and request response works now over WebRTC. Pull-Request: libp2p#5439.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5438
Description
This PR adds a return of
Poll::Ready(Ok(0))when themessagevector is empty or not present.This missing return was causing the stream not to finish, then to be dropped, causing the request response protocol to fail over WebRTC.
Now that empty or non existent message vectors get returned as
Ok(0)the stream can be read and request response works now over WebRTC.Notes & open questions
I don't think there are any specific tests for request response over WebRTC, though I believe @jxs is working on a branch for them?
Change checklist