Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the MemoryTransport to be more similar to the TcpConfig #913

Closed
tomaka opened this issue Feb 4, 2019 · 0 comments
Closed

Rewrite the MemoryTransport to be more similar to the TcpConfig #913

tomaka opened this issue Feb 4, 2019 · 0 comments

Comments

@tomaka
Copy link
Member

tomaka commented Feb 4, 2019

The problem with the memory transport right now is that it's too limited. We can't test discovery with it, for example.
Instead we should, in my opinion, allow addresses like /memory/<port>, and have some sort of static global hub similar to localhost TCP/IP connections.

Considering the usage of MemoryTransport everywhere, I would suggest creating a different struct and deprecating the old one, instead of simply rewriting the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant