Add NetworkBehaviour::inject_replaced #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
gnunicorn
approved these changes
Feb 4, 2019
| @@ -191,6 +191,28 @@ fn build_struct(ast: &DeriveInput, data_struct: &DataStruct) -> TokenStream { | |||
| }) | |||
| }; | |||
|
|
|||
| // Build the list of statements to put in the body of `inject_replaced()`. | |||
| let inject_replaced_stmts = { | |||
| let num_fields = data_struct.fields.iter().filter(|f| !is_ignored(f)).count(); | |||
There was a problem hiding this comment.
are you doing this count and all the rather complex looking code below only to save three clones? Are these three structs so heavy that this warrants the extra looping and increased code complexity?
There was a problem hiding this comment.
Yes! The plan is to ultimately remove this custom derive, which is why no effort has been put into making its code more readable.
misc/core-derive/src/lib.rs
Outdated
| } | ||
| } else { | ||
| match field.ident { | ||
| Some(ref i) => quote!{ self.#i.inject_replaced(peer_id.clone(), closed_endpoint.clone(), new_endpoint.clone()); }, |
There was a problem hiding this comment.
please wrap - this and the line below.
|
I pushed another commit that adds a call to |
|
Also pushed another commit that adds the incoming address to kbuckets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling "disconnected" followed with "connected", allows implementers to override an
inject_replacedmethod.The Kademlia behaviour needs this so that it can re-send the RPC query without marking the node as unreachable.