Update multistream-select to stable futures #1484
Merged
+838
−639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently building Polkadot with this PR (as a way to fuzz the code), and will report how it goes. |
mxinden
approved these changes
Mar 7, 2020
romanb
pushed a commit
to romanb/rust-libp2p
that referenced
this pull request
Oct 5, 2020
Fixes a panic when using the `V1Lazy` negotiation protocol, a regression introduced in libp2p#1484. Thereby adds integration tests for a transport upgrade with both `V1` and `V1Lazy` to the `multistream-select` crate to prevent future regressions.
romanb
added a commit
that referenced
this pull request
Oct 7, 2020
…nvenient transport boxing. (#1783) * [multistream-select] Fix panic with V1Lazy and add integration tests. Fixes a panic when using the `V1Lazy` negotiation protocol, a regression introduced in #1484. Thereby adds integration tests for a transport upgrade with both `V1` and `V1Lazy` to the `multistream-select` crate to prevent future regressions. * Cleanup. * Update changelog.
santos227
pushed a commit
to santos227/rustlib
that referenced
this pull request
Jun 20, 2022
…nvenient transport boxing. (#1783) * [multistream-select] Fix panic with V1Lazy and add integration tests. Fixes a panic when using the `V1Lazy` negotiation protocol, a regression introduced in libp2p/rust-libp2p#1484. Thereby adds integration tests for a transport upgrade with both `V1` and `V1Lazy` to the `multistream-select` crate to prevent future regressions. * Cleanup. * Update changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1331
This is a less sexy version of #1331, where we just do a one-to-one conversion to futures 0.3, without attempting to use
async/await.Using
async/awaitat such a low level means that we have to box futures, which means that we have to enforceSendand'staticeverywhere, which isn't great.After this PR,
futures 0.1has disappeared from myCargo.lock.