swarm/src/protocols_handler: Use FuturesUnordered in NodeHandlerWrapper #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Futures managed by FuturesUnordered will only be polled when they generate wake-up notifications. This reduces the required amount of work needed to poll large numbers of futures. https://docs.rs/futures/0.3.5/futures/stream/struct.FuturesUnordered.html Instead of iterating each inbound and outbound upgrade looking for one to make progress, use a `FuturesUnordered` for both pending inbound and pending outbound upgrades. As a result only those upgrades are polled that are ready to progress.
tomaka
approved these changes
Oct 1, 2020
Good point @tomaka . I will add a note in the changelog so we don't forget. |
mxinden
commented
Oct 9, 2020
| @@ -2,7 +2,7 @@ | |||
| name = "libp2p-swarm" | |||
| edition = "2018" | |||
| description = "The libp2p swarm" | |||
| version = "0.22.0" | |||
| version = "0.22.1" | |||
There was a problem hiding this comment.
I am declaring this as a non-breaking change, thus bumping the patch version only. Let me know in case you prefer a minor version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.rs/futures/0.3.5/futures/stream/struct.FuturesUnordered.html
Instead of iterating each inbound and outbound upgrade looking for one
to make progress, use a
FuturesUnorderedfor both pending inbound andpending outbound upgrades. As a result only those upgrades are polled
that are ready to progress.