Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Switch futures_codec to asynchronous-codec #1908

Merged
merged 5 commits into from
Jan 12, 2021

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Jan 6, 2021

futures-codec has not been updated in the recent months. It still
depends on bytes v0.5 preventing all downstream dependencies to
upgrade to bytes v1.0.

This commit replaces futures_codec in favor of asynchronous-codec
The latter is a fully upgraded fork of the former.

Closes #1900. Depends on paritytech/unsigned-varint#47.

See also matthunz/futures-codec#51 and matthunz/futures-codec#57.

In addition to the above, this pull request upgrades rust-libp2p to bytes v1.

`futures-codec` has not been updated in the recent months. It still
depends on `bytes` `v0.5` preventing all downstream dependencies to
upgrade to `bytes` `v1.0`.

This commit replaces `futures_codec` in favor of `asynchronous-codec`
The latter is a fully upgraded fork of the former.
Copy link
Contributor

@romanb romanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. We should merge this before #1887, since you already made the version and changelog updates here.

protocols/identify/Cargo.toml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants