swarm/src/either: implement NetworkBehaviour on Either
#2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement `NetworkBehaviour` on `either::Either<L, R>` where both L and R both implement `NetworkBehaviour`. Add NetworkBehaviour derive tests for Either and Toggle
mxinden
reviewed
Dec 8, 2021
There was a problem hiding this comment.
Thank you @mexskican for picking this up!
Looks good to me, just a couple of smaller comments. Great job getting familiar with these somewhat complicated internals!
While reviewing I had the idea described in #2374. I would be interested in your opinion @mexskican.
thomaseizinger
approved these changes
Dec 8, 2021
swarm/src/either.rs
Outdated
Comment on lines
43
to
46
| match self { | ||
| Either::Left(a) => IntoEitherHandler::Left(a.new_handler()), | ||
| Either::Right(b) => IntoEitherHandler::Right(b.new_handler()), | ||
| } |
There was a problem hiding this comment.
It is a pity rayon-rs/either#58 is not merged / released yet ...
mxinden
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2353
Implement
NetworkBehaviouroneither::Either<L, R>where both Land R implement
NetworkBehaviour.Add
NetworkBehaviourderive tests for Either and Toggle