Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Metrics as weak dependency #2646

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Set Metrics as weak dependency #2646

merged 4 commits into from
Jun 10, 2022

Conversation

maschad
Copy link
Member

@maschad maschad commented May 12, 2022 •
edited
Loading

Description

Upgraded to 1.60.0 in order to enable metrics as a weak dependency rust-lang/cargo#8832

Links to any relevant issues

#2286

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@maschad maschad mentioned this pull request May 12, 2022
Closed
@maschad maschad changed the title Cargo.toml: upgrade to rust 1.60.0 (#2286) Set Metrics as weak dependency May 12, 2022
thomaseizinger
thomaseizinger requested changes May 14, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

I am okay with the semver bump but I think it should have a changelog entry plus we should use this syntax for all features!

@mxinden
Copy link
Member

mxinden commented May 14, 2022

👍 Also in favor of this. Thanks @maschad!

Do I understand correctly that this forces downstream users to use Rust >= v1.60.0? I am fine with that, though to reduce conflicts, I suggest we merge here after the next release. (Which I am planning to prepare next week.)

@maschad
Copy link
Member Author

maschad commented May 14, 2022 •
edited
Loading

👍 Also in favor of this. Thanks @maschad!

Do I understand correctly that this forces downstream users to use Rust >= v1.60.0? I am fine with that, though to reduce conflicts, I suggest we merge here after the next release. (Which I am planning to prepare next week.)

I believe so seeing as it's the root manifest. @thomaseizinger that's a good idea, will do.

@maschad maschad force-pushed the update-rust-version-1.60.0 branch from e550618 to 8b2192c Compare May 17, 2022 02:06
@maschad
Copy link
Member Author

maschad commented May 17, 2022

I've made some changes. Look forward to your feedback post release of 0.45.0

thomaseizinger
thomaseizinger requested changes May 19, 2022
View reviewed changes
Cargo.toml Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@maschad maschad force-pushed the update-rust-version-1.60.0 branch 3 times, most recently from 1679a45 to 8b7be6d Compare May 19, 2022 19:28
@maschad
Copy link
Member Author

maschad commented May 19, 2022

Thanks for your review @thomaseizinger I have made the requested changes.

@maschad maschad force-pushed the update-rust-version-1.60.0 branch from 8b7be6d to d3b065d Compare May 25, 2022 16:31
thomaseizinger
thomaseizinger reviewed May 27, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@maschad maschad force-pushed the update-rust-version-1.60.0 branch 2 times, most recently from 998e003 to 787607c Compare May 30, 2022 01:02
thomaseizinger
thomaseizinger approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go!

0.45.0 is not released yet so we will have to wait with merging this until that is in. Thank you for your effort and contribution :)

@maschad maschad force-pushed the update-rust-version-1.60.0 branch from 787607c to 4854633 Compare May 31, 2022 14:59
@maschad
Copy link
Member Author

maschad commented May 31, 2022

I updated the Changelog again given the release of 0.45.0

@maschad maschad force-pushed the update-rust-version-1.60.0 branch 2 times, most recently from 25d8451 to c0df16a Compare June 2, 2022 22:55
thomaseizinger
thomaseizinger approved these changes Jun 3, 2022
View reviewed changes
Cargo.toml Show resolved Hide resolved
@maschad maschad force-pushed the update-rust-version-1.60.0 branch from c0df16a to ba7e327 Compare June 3, 2022 14:40
@mxinden
Copy link
Member

mxinden commented Jun 7, 2022

Thanks for the continued work here! I will do a couple of patch releases off of master this week. Will merge this afterwards.

mxinden
mxinden approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maschad and @thomaseizinger!

@mxinden mxinden merged commit 2fd4998 into libp2p:master Jun 10, 2022
paulchoi0619 added a commit to paulchoi0619/rust-libp2p that referenced this pull request Jun 12, 2022
@paulchoi0619
Revert "Cargo.toml: Use Rust 1.60.0 and weak dependency for feats (li…
59d250f 
…bp2p#2646)"

This reverts commit 2fd4998.
@jxs jxs mentioned this pull request Nov 10, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maschad @mxinden @thomaseizinger