Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

muxers/mplex/benches: Use combinators to reduce nesting #2688

Merged
merged 3 commits into from
Jun 3, 2022
Merged

muxers/mplex/benches: Use combinators to reduce nesting #2688

merged 3 commits into from
Jun 3, 2022

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Jun 2, 2022 •
edited
Loading

Description

Instead of matching on the result, we can use combinators to directly
extract the substream from the event.

Links to any relevant issues

Will make the diff in #2648 smaller.

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger requested review from elenaf9 and mxinden June 2, 2022 11:38
@thomaseizinger thomaseizinger mentioned this pull request Jun 2, 2022
Closed
27 tasks
mxinden
mxinden approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Much better! Thanks.

@mxinden mxinden merged commit fcc987e into libp2p:master Jun 3, 2022
@thomaseizinger thomaseizinger mentioned this pull request Jun 22, 2022
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenaf9 elenaf9 elenaf9 approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaseizinger @mxinden @elenaf9