misc/metrics: Use correct event name for dcutr metrics #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
reviewed
Jun 20, 2022
There was a problem hiding this comment.
Good catch. Thanks @dignifiedquire!
Mind bumping libp2p-metrics to v0.6.1 and adding a changelog entry to misc/metrics/CHANGELOG.md? I can cut a patch release once merged.
Currently when both the `relay` and `dcutr` features are enabled this generates an error.
dignifiedquire
force-pushed
the
fix-metrics-dcutr
branch
from
99de8ef to
520e321
Compare
|
done |
dignifiedquire
force-pushed
the
fix-metrics-dcutr
branch
from
520e321 to
3960fce
Compare
thomaseizinger
changed the title
mxinden
reviewed
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when both the
relayanddcutrfeatures are enabled this generates an error.Description
Currently when both the
relayanddcutrfeatures are enabled this generates an error.Change checklist