swarm-derive: Allow for templated behaviours #2907
Merged
+82
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
commented
Sep 15, 2022
mxinden
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Thanks for debugging and patching @thomaseizinger. Thanks @dmitry-markin for confirming.
@dmitry-markin let me know in case you need this released rather sooner than later.
|
Testground failures are due to libp2p/test-plans#41. Merging here. |
@mxinden it would be great to have this released to merge paritytech/substrate#12256 and be able to finally use #2846. But this is not super-urgent. |
|
@dmitry-markin you can follow the progress on the next release here: #2931 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes an issue where we couldn't use type parameters on a behaviour with a custom out event that had different type parameters.
Links to any relevant issues
Fixes #2879.
Open Questions
Change checklist
- [ ] I have made corresponding changes to the documentation