feat(relay): hide internals of Connection

[tcoratger]

Description

Relayed connections to other peers are created from streams to the relay itself. Internally, such a connection has different states. These however are not relevant to the user and should be encapsulated to allow for more backwards-compatible changes. The only interface exposed is AsyncRead and AsyncWrite.

Resolves: #3255.

Notes & open questions

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• A changelog entry has been made in the appropriate crates

[thomaseizinger]

Thanks!

This looks good. Unfortunately, it is a breaking change so I'll add it to the milestone. We are looking at cutting a new breaking release soon though so we will hopefully be able to merge this in the next couple of weeks.

[thomaseizinger]

I've converted it to a draft. We do this for all PRs that are queued to only be merged for the next breaking release.

[tcoratger]

@thomaseizinger Is there anything left to do here or is it just waiting for the next release?

[thomaseizinger]

@thomaseizinger Is there anything left to do here or is it just waiting for the next release?

Nothing to do, we are just waiting for the next breaking change which will very likely happen next week!

See #3532 for some context on the strategy we are following.

[thomaseizinger]

Can you add a changelog entry for this please? We can then queue it for merging!

[tcoratger]

Can you add a changelog entry for this please? We can then queue it for merging!

@thomaseizinger Done

[thomaseizinger]

Solid, thank you! 🚀