refactor(tcp): reducing branching in Transport::create_socket

[jxs]

and add test for listening on ipv4 and ipv6 separately.

Description

Following #4289 (comment), hereby is the PR to also improve the create_socket using for_addr. We also add a test for listening on IPv4 and IPv6 separately.

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[mxinden]

Thank you for the follow-up.

[mxinden]

I suggest having the operating system choose any free port. In case someone has e.g. a go-ipfs node running on 4001 their unit tests would still succeed.

[jxs]

I suggest having the operating system choose any free port. In case someone has e.g. a go-ipfs node running on 4001 their unit tests would still succeed.

but that defeats the purpose of the test no? I.e. being certain that ipv4 and ipv6 run in the same port. I can try something else nonetheless.

[mxinden]

Ah, yes, sorry. My bad. How about a more random port than 4001, or even better first assign a random port for v4 by the OS and then use the same port for v6?

[thomaseizinger]

You can use a TcpListener to first bind a random port, retrieve the port, drop the listener and then bind to it again :)

[jxs]

You can use a TcpListener to first bind a random port, retrieve the port, drop the listener and then bind to it again :)

yup exactly 😁. Meanwhile also updated the Quic test, if wanted I can move it instead do a new PR aha

[mxinden]

Neat. Thank you. Fine to merge in one pull request.

[thomaseizinger]

@mxinden Why is the cargo-deny job suddenly required? It only runs on changes to Cargo.toml files which is not the case in all PRs. I can't see it here: https://github.com/libp2p/github-mgmt/blame/master/github/libp2p.yml#L7074-L7126

[mxinden]

@mergify refresh

[mergify]

refresh

✅ Pull request refreshed

[mxinden]

@mxinden Why is the cargo-deny job suddenly required? It only runs on changes to Cargo.toml files which is not the case in all PRs. I can't see it here: https://github.com/libp2p/github-mgmt/blame/master/github/libp2p.yml#L7074-L7126

My bad. I changed it through the UI without thinking it all the way through. Thanks for catching. Sorry for the debugging time wasted on this.

What do you think of running it on all changes, simply succeeding right away on non-Cargo.toml changes @thomaseizinger? I would like to get to a place where one does not have to manually check for non-required failures.

[thomaseizinger]

What do you think of running it on all changes, simply succeeding right away on non-Cargo.toml changes @thomaseizinger? I would like to get to a place where one does not have to manually check for non-required failures.

I think we can simply add it to the CI workflow. I don't see why it shouldn't run on all code changes. It is slightly wasteful in terms of resource usage but I don't think it weighs in very heavily for the gained simplicity in the setup.

[mxinden]

Sounds good. Let me know what you think of #4352.