-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(tls): switch from webpki to rustls-webpki #4381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the help here.
I am not deeply familiar with webpki
and rustls-webpki
history. In case there are any resources you can point me to, that would be much appreciated.
I'm not that familiar myself, but the report at https://rustsec.org/advisories/RUSTSEC%2D2023%2D0052.html suggests that it is a maintained version, while from the looks of it the original See https://github.com/rustls/webpki and https://github.com/briansmith/webpki. |
010736e
to
38fc9a9
Compare
I think this is ready to merge now; I'm afraid this is the last low-hanging fruit here, and the rest requires going to It's unlikely I'll be going that myself in the near future, but hey there are plenty of other people who might be willing to fix it there, so I suggest just keeping an eye on the rest of the deps for now and waiting a bit to see if maybe they ship a new, fixed version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :)
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
Description
A simple dependency update to make the CVE detector happy.
Continuation of #4378.
Notes & open questions
This is a part of the work to make https://rustsec.org/advisories/RUSTSEC-2023-0052.html alerts go away.
Change checklist