Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(tls): switch from webpki to rustls-webpki #4381

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Aug 23, 2023

Description

A simple dependency update to make the CVE detector happy.
Continuation of #4378.

Notes & open questions

This is a part of the work to make https://rustsec.org/advisories/RUSTSEC-2023-0052.html alerts go away.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help here.

I am not deeply familiar with webpki and rustls-webpki history. In case there are any resources you can point me to, that would be much appreciated.

transports/quic/CHANGELOG.md Outdated Show resolved Hide resolved
transports/tls/Cargo.toml Show resolved Hide resolved
@MOZGIII MOZGIII changed the title deps(quic): switch from webpki to rustls-webpki deps(tls): switch from webpki to rustls-webpki Aug 23, 2023
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Aug 23, 2023

Thank you for the help here.

I am not deeply familiar with webpki and rustls-webpki history. In case there are any resources you can point me to, that would be much appreciated.

I'm not that familiar myself, but the report at https://rustsec.org/advisories/RUSTSEC%2D2023%2D0052.html suggests that it is a maintained version, while from the looks of it the original webpki is indeed unmaintained - last commit was 2 years ago.

See https://github.com/rustls/webpki and https://github.com/briansmith/webpki.

@MOZGIII MOZGIII force-pushed the webpki-quic branch 2 times, most recently from 010736e to 38fc9a9 Compare August 23, 2023 21:48
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Aug 23, 2023

I think this is ready to merge now; I'm afraid this is the last low-hanging fruit here, and the rest requires going to webrtc and other upstreams and fixing it there.

It's unlikely I'll be going that myself in the near future, but hey there are plenty of other people who might be willing to fix it there, so I suggest just keeping an eye on the rest of the deps for now and waiting a bit to see if maybe they ship a new, fixed version.

thomaseizinger
thomaseizinger previously approved these changes Aug 24, 2023
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@mergify mergify bot dismissed thomaseizinger’s stale review August 24, 2023 07:28

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit 240c5c2 into libp2p:master Aug 24, 2023
@mxinden mxinden mentioned this pull request Aug 24, 2023
4 tasks
mergify bot pushed a commit that referenced this pull request Aug 24, 2023
- Addresses TLS CVE:
- #4381
- #4378
- Stable QUIC #4325
- New rust-libp2p-server release #4311

Pull-Request: #4387.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants