Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gossipsub): process send-queue before inbound stream #4778

Merged
merged 4 commits into from
Nov 14, 2023
Merged

feat(gossipsub): process send-queue before inbound stream #4778

merged 4 commits into from
Nov 14, 2023

Conversation

0xcrust
Copy link
Contributor

@0xcrust 0xcrust commented Nov 1, 2023 •
edited by thomaseizinger
Loading

Description

Process outbound stream before inbound stream in gossipsub::EnabledHandler::poll(..).

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@0xcrust 0xcrust changed the title feat(gossipsub): prioritize send-queue processing ahead of inbound stream feat(gossipsub): process send-queue before inbound stream Nov 1, 2023
@0xcrust 0xcrust marked this pull request as draft November 1, 2023 22:41
thomaseizinger
thomaseizinger reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

protocols/gossipsub/src/handler.rs Outdated Show resolved Hide resolved
protocols/gossipsub/CHANGELOG.md Outdated Show resolved Hide resolved
@0xcrust 0xcrust marked this pull request as ready for review November 2, 2023 20:05
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

This pull request has merge conflicts. Could you please resolve them @0xcrust? 🙏

@0xcrust 0xcrust force-pushed the gossipsub/poll-order branch from e0d18e9 to 646f364 Compare November 2, 2023 20:54
thomaseizinger
thomaseizinger approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Should we even mention this in the changelog? Could be considered an implementation detail?

@thomaseizinger
Copy link
Contributor

Should we even mention this in the changelog? Could be considered an implementation detail?

Deferring this to @mxinden.

thomaseizinger
thomaseizinger approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is been two weeks, lets get it in :)

@mergify mergify bot merged commit 22f1e23 into libp2p:master Nov 14, 2023
71 checks passed
mxinden
mxinden reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden left review comments

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xcrust @thomaseizinger @mxinden