Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(relay): emit external address on reservation #4809

Merged
merged 26 commits into from
Nov 14, 2023
Merged

feat(relay): emit external address on reservation #4809

merged 26 commits into from
Nov 14, 2023

Conversation

dariusc93
Copy link
Member

@dariusc93 dariusc93 commented Nov 6, 2023 •
edited
Loading

Description

Resolves #4618.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

thomaseizinger
thomaseizinger reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! Two comments :)

protocols/relay/tests/lib.rs Show resolved Hide resolved
protocols/relay/src/priv_client.rs Outdated Show resolved Hide resolved
protocols/relay/src/priv_client.rs Outdated Show resolved Hide resolved
thomaseizinger
thomaseizinger reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Couple more comments :)

protocols/relay/src/priv_client.rs Outdated Show resolved Hide resolved
protocols/relay/tests/lib.rs Outdated Show resolved Hide resolved
protocols/relay/CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title feat(relay): Emit external address on reservation feat(relay): emit external address on reservation Nov 9, 2023
thomaseizinger
thomaseizinger reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd like to iterate on the implementations details a bit more to make it easier to understand.

protocols/relay/src/priv_client.rs Outdated Show resolved Hide resolved
protocols/relay/src/priv_client.rs Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger marked this pull request as ready for review November 14, 2023 00:55
@mergify mergify bot merged commit cf8a24d into libp2p:master Nov 14, 2023
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

relay: making a reservation should emit an external address
2 participants
@dariusc93 @thomaseizinger