Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade thiserror to 2.0 #5689

Merged
merged 3 commits into from
Nov 25, 2024
Merged

chore(deps): upgrade thiserror to 2.0 #5689

merged 3 commits into from
Nov 25, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Nov 25, 2024 •
edited
Loading

Description

Changes:

  • upgrade thiserror crate from 1 to 2
  • move thiserror to workspace.dependencies
  • sort workspace.dependencies
  • run cargo update to update Cargo.lock
    (Skipping changelog as thiserror does not present in any public APIs)

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@hanabi1224 hanabi1224 force-pushed the upgrade-thiserror branch 2 times, most recently from a88e315 to a1856b9 Compare November 25, 2024 11:57
@hanabi1224 hanabi1224 marked this pull request as ready for review November 25, 2024 12:19
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

This pull request has merge conflicts. Could you please resolve them @hanabi1224? 🙏

jxs
jxs reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

run cargo update to update Cargo.lock

this is currently breaking the webrtc tests and it's also possibly what's issuing the clippy warnings, can you checkout master's Cargo.lock and only update thiserror and its direct dependencies?
Thanks!

@hanabi1224
Copy link
Contributor Author

can you checkout master's Cargo.lock and only update thiserror and its direct dependencies?

@jxs Done.

this is currently breaking the webrtc tests

This might indicate an issue with webrtc as crate users won't use the same Cargo.lock in this repo

jxs
jxs approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This might indicate an issue with webrtc as crate users won't use the same Cargo.lock in this repo

Yeah, we plan to deprecate it and replace it with str0m see #3659

@jxs jxs added the send-it label Nov 25, 2024
@mergify mergify bot merged commit b057f91 into libp2p:master Nov 25, 2024
71 of 72 checks passed
@hanabi1224 hanabi1224 deleted the upgrade-thiserror branch November 26, 2024 05:01
jxs pushed a commit to jxs/rust-libp2p that referenced this pull request Jan 6, 2025
@hanabi1224 @jxs
chore(deps): upgrade thiserror to 2.0
3f0533d 
Changes:
- upgrade `thiserror` crate from `1` to `2`
- move `thiserror` to `workspace.dependencies`
- sort `workspace.dependencies`
- ~run `cargo update` to update `Cargo.lock`~
(Skipping changelog as `thiserror` does not present in any public APIs)

Pull-Request: libp2p#5689.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanabi1224 @jxs